Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong branch name in link to cheatsheet #1226

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix wrong branch name in link to cheatsheet #1226

merged 1 commit into from
Jul 1, 2024

Conversation

matrss
Copy link
Contributor

@matrss matrss commented Jun 26, 2024

Clicking on the image in the handbook leads to a 404. This PR fixes the link.

@welcome Welcome
Copy link

welcome bot commented Jun 26, 2024

Thank You Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Wohoo! 🎉 Thanks for opening your first pull request to the DataLad Handbook! 😎 We really appreciate your time and effort to contribute to the project - you're amazing! 👏

mslw
mslw approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mslw mslw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we might want to switch the artwork repo's default branch to main for consistency with the catalog repo, at which point your commit would need to be reverted - but I also see no reason not to use your patch as a quick fix.

FTR the 404 link was introduced in what seems to be an automated change across several files: 29b719c

adswa
adswa approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@adswa adswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks much! This was a side effect from updating the default branch name in this repo... I agree with merging this atm

@adswa adswa merged commit 68453a3 into datalad-handbook:main Jul 1, 2024
2 of 3 checks passed
@welcome Welcome
Copy link

welcome bot commented Jul 1, 2024

Congratulations Banner (Image: CC-BY license, The Turing Way Community, & Scriberia. Zenodo. https://doi.org/10.5281/zenodo.3332808) Congrats on merging your first pull request! 🎉 The DataLad Handbook team appreciates your contribution greatly, and we want to say thanks! 💖 Now go ahead and share your first merge with your colleagues, you got yourself this brag right! 😄 🎁

@adswa
Copy link
Contributor

adswa commented Jul 1, 2024

@all-contributors please add @matrss for bug

@allcontributors allcontributors bot mentioned this pull request Jul 1, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@adswa

I've put up a pull request to add @matrss! 🎉

@adswa
Copy link
Contributor

adswa commented Jul 1, 2024

Feel free to add yourself to the .zenodo.json file of this repository (as second to last, before Michael Hanke), or leave your details in a comment here and I'll add you, @matrss :)

@matrss matrss mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adswa adswa adswa approved these changes

@mslw mslw mslw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matrss @adswa @mslw